testrunner: fix clang compile error related to dinit#5297
Merged
firewave merged 5 commits intocppcheck-opensource:mainfrom Aug 8, 2023
Merged
testrunner: fix clang compile error related to dinit#5297firewave merged 5 commits intocppcheck-opensource:mainfrom
dinit#5297firewave merged 5 commits intocppcheck-opensource:mainfrom
Conversation
Collaborator
|
What compile error? Please specify. Maybe that |
firewave
reviewed
Aug 6, 2023
firewave
reviewed
Aug 6, 2023
Collaborator
|
Sorry, I didn't see the previous PR. So it seems that workaround can be removed. |
Collaborator
|
This is really strange that you encounter this. I tried Clang 10 to 18 to see what can be cleaned up but none of those give any errors or warnings with the trunk. |
danmar
reviewed
Aug 8, 2023
firewave
changed the title
dinit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the compile error introduced in 5d201c4.